Skip to content

added #includes for compilation on g++ 4.4.3#1

Open
daler wants to merge 1 commit into
arq5x:masterfrom
daler:master
Open

added #includes for compilation on g++ 4.4.3#1
daler wants to merge 1 commit into
arq5x:masterfrom
daler:master

Conversation

@daler

@daler daler commented Mar 2, 2011

Copy link
Copy Markdown

I had trouble compiling filo in Ubuntu 10.04, which has gcc/g++ version 4.4.3 in the repos. Upon compiling, I got errors like

shuffle.cpp:32: error: ‘strlen’ was not declared in this scope

So I made minor tweaks to stats.cpp and shuffle.cpp as described in http://gcc.gnu.org/gcc-4.3/porting_to.html and now it works like a charm. Hopefully these #includes are backwards-compatible?

-ryan

@arq5x

arq5x commented Mar 2, 2011

Copy link
Copy Markdown
Owner

Thanks Ryan, I will incorporate these changes. I think it's time for me to update my compiler...

@brentp

brentp commented Jun 4, 2011

Copy link
Copy Markdown

+1 I just did this same patch for limits + string and came here to report.

gcc-4.5 also gives a warning:

stats.cpp:57:57: warning: suggest parentheses around ‘&&’ within ‘||’
  * linking stats

for your argument parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants