Fix sefault when given no data#8
Open
kdm9 wants to merge 1 commit into
Open
Conversation
Author
|
Hi again Aaron, Would it be possible to create and push to github a git tag for the latest release (probably after merging this PR)? This allows distributions like Debian to automatically watch for updates and helps keep the packaged version up to date with any changes in this repository. Cheers, |
|
I'm in need of releases too (see #9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
Project Mayhem, and effort to fuzz-test all Debian packages, found an issue with the stats command which causes a segfault when given no data. I have patched the filo package with the attached patch, and confirmed that it fixes the bug.
In short, during calculation of the mid-point for the median, and index of -1 is generated and used when no data is present (
totalLines == 0). This patch skips all further operations when there are no lines to process.