Added JSON output feature for inheritance tools as per issue #752#838
Open
michael-ford wants to merge 3 commits intoarq5x:masterfrom
Open
Added JSON output feature for inheritance tools as per issue #752#838michael-ford wants to merge 3 commits intoarq5x:masterfrom
michael-ford wants to merge 3 commits intoarq5x:masterfrom
Conversation
brentp
requested changes
Apr 19, 2017
Collaborator
brentp
left a comment
brentp
left a comment
There was a problem hiding this comment.
thanks, this looks good. I've made suggestions inline.
| dest='format', | ||
| default='default', | ||
| help='Format of output (JSON or default)' | ||
| ) |
Collaborator
There was a problem hiding this comment.
If all of the inheritance tools have this option, can you put this into the add_inheritance_args function?
| default='default', | ||
| help='Format of output (JSON or default)' | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
... into add_inheritance_args and same with below.
| if i == 0: | ||
| has_gts = [x[0] for x in gt_cols_types if x[0] in s] or False | ||
| print("\t".join(s.keys())) | ||
| if self.args.format is 'default': print("\t".join(s.keys())) |
Collaborator
There was a problem hiding this comment.
don't use is for string equality. use ==. It will probably always work due to interning, but makes me nervous.
| yield item | ||
|
|
||
| def run(self): | ||
| test = [] |
Collaborator
There was a problem hiding this comment.
name this something more descriptive than test please
Collaborator
There was a problem hiding this comment.
and define res or a better-named variable below where it's used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of a course project we needed to contribute to an open-source database project so we have attempted to address issue #752 for Gemini. We used the argument format from the query command.