Conversation
Update methods to avoid deprecated calls. That makes the code compatible with QUnit 2.x.
QUnit.assert.push will get deprecated - not removed on QUnit 2.x. This patch updates the current API to use pushResult instead.
|
@arschmitz, please accept this pull request and publish the new package version. |
Owner
|
I some how missed this when it was opened ill review and release asap |
arschmitz
requested changes
Jul 26, 2017
Owner
arschmitz
left a comment
arschmitz
left a comment
There was a problem hiding this comment.
Just remove that one change to the license and i think this should be good
| externally maintained libraries used by this software which have their | ||
| own licenses; we recommend you read them, as their terms may differ from | ||
| the terms above. | ||
| All files located in the node_modules directory are externally maintained |
Owner
There was a problem hiding this comment.
this change is not correct. QUnit still lives in the external directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last commit (cccf688) is not necessary to turn this project compatible with QUnit 2.0.0, but that adds an extra update to avoid future deprecations.