Create APIS import task and wait for status#180
Conversation
|
Just missing the OIDC provider configuration and setup, similar to what we do in Enduro with the gotools/clientauth package. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 61.23% 60.59% -0.65%
==========================================
Files 43 47 +4
Lines 2515 2776 +261
==========================================
+ Hits 1540 1682 +142
- Misses 830 942 +112
- Partials 145 152 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f84e56f to
f84fc5b
Compare
djjuhasz
left a comment
There was a problem hiding this comment.
Looking good @jraddaoui. I had a handful of minor notes, but the structure looks good. I think it's a really good decision to add a config gate for the APIS functionality so the workflow can run without communicating with the APIS server if necessary.
f84fc5b to
de83190
Compare
5f4ec24 to
4657c59
Compare
de83190 to
b8fed7f
Compare
|
Thanks for the review @djjuhasz! I think I have addressed all feedback, and I have added the enabled config toggle and the OIDC provider setup and configuration. Ready for another look. |
djjuhasz
left a comment
There was a problem hiding this comment.
This looks great @jraddaoui. I suggested a couple of minor wording changes to the system error messages, but you can take them or leave them. 👍
b8fed7f to
1b2c319
Compare
- Add generated APIS API client. - Add initial APIS API client config and implementation. - Add APIS activities to create import task and poll status. - Create preprocessing tasks for both activities. [skip-codecov]
1b2c319 to
5d9195a
Compare
Refs #173.