Skip to content

Create APIS import task and wait for status#180

Merged
jraddaoui merged 1 commit intomainfrom
dev/issue-173-apis-import-task
Mar 26, 2026
Merged

Create APIS import task and wait for status#180
jraddaoui merged 1 commit intomainfrom
dev/issue-173-apis-import-task

Conversation

@jraddaoui
Copy link
Copy Markdown
Contributor

@jraddaoui jraddaoui commented Mar 13, 2026

  • Add generated APIS API client.
  • Add initial APIS API client config and implementation.
  • Add APIS activities to create import task and poll status.
  • Create preprocessing tasks for both activities.

Refs #173.

@jraddaoui jraddaoui requested a review from djjuhasz March 13, 2026 08:40
@jraddaoui jraddaoui self-assigned this Mar 13, 2026
@jraddaoui
Copy link
Copy Markdown
Contributor Author

Just missing the OIDC provider configuration and setup, similar to what we do in Enduro with the gotools/clientauth package.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

❌ Patch coverage is 54.30712% with 122 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.59%. Comparing base (4657c59) to head (b8fed7f).

Files with missing lines Patch % Lines
internal/workflow/preprocessing.go 49.52% 49 Missing and 4 partials ⚠️
cmd/worker/workercmd/cmd.go 0.00% 22 Missing ⚠️
internal/apis/create_import_task_activity.go 58.82% 18 Missing and 3 partials ⚠️
internal/apis/client.go 37.50% 15 Missing ⚠️
internal/apis/poll_import_task_status_activity.go 82.97% 7 Missing and 1 partial ⚠️
internal/apis/config.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   61.23%   60.59%   -0.65%     
==========================================
  Files          43       47       +4     
  Lines        2515     2776     +261     
==========================================
+ Hits         1540     1682     +142     
- Misses        830      942     +112     
- Partials      145      152       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-import-task branch from f84e56f to f84fc5b Compare March 13, 2026 09:03
Copy link
Copy Markdown
Contributor

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @jraddaoui. I had a handful of minor notes, but the structure looks good. I think it's a really good decision to add a config gate for the APIS functionality so the workflow can run without communicating with the APIS server if necessary.

@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-import-task branch from f84fc5b to de83190 Compare March 24, 2026 16:59
@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-mock branch from 5f4ec24 to 4657c59 Compare March 24, 2026 20:03
Base automatically changed from dev/issue-173-apis-mock to main March 24, 2026 20:08
@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-import-task branch from de83190 to b8fed7f Compare March 25, 2026 02:07
@jraddaoui jraddaoui changed the title WIP: Create APIS import task and wait for status Create APIS import task and wait for status Mar 25, 2026
@jraddaoui
Copy link
Copy Markdown
Contributor Author

Thanks for the review @djjuhasz! I think I have addressed all feedback, and I have added the enabled config toggle and the OIDC provider setup and configuration. Ready for another look.

@jraddaoui jraddaoui requested a review from djjuhasz March 25, 2026 02:10
Copy link
Copy Markdown
Contributor

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @jraddaoui. I suggested a couple of minor wording changes to the system error messages, but you can take them or leave them. 👍

@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-import-task branch from b8fed7f to 1b2c319 Compare March 26, 2026 00:49
- Add generated APIS API client.
- Add initial APIS API client config and implementation.
- Add APIS activities to create import task and poll status.
- Create preprocessing tasks for both activities.

[skip-codecov]
@jraddaoui jraddaoui force-pushed the dev/issue-173-apis-import-task branch from 1b2c319 to 5d9195a Compare March 26, 2026 00:53
@jraddaoui jraddaoui merged commit 5d9195a into main Mar 26, 2026
5 checks passed
@jraddaoui jraddaoui deleted the dev/issue-173-apis-import-task branch March 26, 2026 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants