fix: preserve active task category filters in URL query parameters#1151
Open
anshull-saxena wants to merge 2 commits into
Open
fix: preserve active task category filters in URL query parameters#1151anshull-saxena wants to merge 2 commits into
anshull-saxena wants to merge 2 commits into
Conversation
- Replace useState(selectedCategories) with useSearchParams from react-router-dom - Read initial filter state from ?categories= query param on mount - Update URL params on category pill click to persist across reloads - Clear query params when 'Clear all' is clicked Closes aryandas2911#1084
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR persists the “Filter by Category” state in the URL query string so category selections survive refresh/share/back-forward navigation.
Changes:
- Switch from local
selectedCategoriesstate to deriving it fromuseSearchParams(). - Update category toggling and “Clear all” to write to the
categoriesquery param.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const next = selectedCategories.includes(categoryName) | ||
| ? selectedCategories.filter((cat) => cat !== categoryName) | ||
| : [...selectedCategories, categoryName]; | ||
| setSearchParams(next.length > 0 ? { categories: next.join(",") } : {}); |
| {selectedCategories.length > 0 && ( | ||
| <button | ||
| onClick={() => setSelectedCategories([])} | ||
| onClick={() => setSearchParams({})} |
- Create reusable ToastContext with framer-motion animated toasts - Wrap app with ToastProvider in App.jsx - Replace all alert() calls with toast notifications across: - useTasks.js (create/update/delete/bulk CRUD feedback) - Tasks.jsx (duration validation) - RoutineBuilder.jsx (save/delete/export/add task) - RoutineCard.jsx (start/stop/delete, remove inline toast divs) - Dashboard.jsx (duplicate routine) - TaskFormModal.jsx (date validation) - Analytics.jsx (export feedback) - Profile.jsx (name/password updates) Closes aryandas2911#1082
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1084
Changes:
useState(selectedCategories)withuseSearchParamsfrom react-router-dom?categories=Work,Personalquery param on mountTesting:
npm run buildpasses clean/tasks?categories=Homework,Creativeare shareable