Basic assignment of scalar values into the tree #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The YAML Pointer path is represented as an STC vector of asdf_yaml_path_component_t which I think is useful. Considered writing an implementation that doesn't parse the full path at once, but just iterates over it, but the problem with that is that it wouldn't necessarily detect from the start if the path is invalid, so we parse the full path in one pass. gh-104
This is a *lot* of string duplication O(n^2) roughly, so not great, and I don't think we need it either. Could hypothetically add it back in later but without the needless duplication gh-104
strange, worked for me locally, I guess it's a matter of what order includes end up happening in... gh-104
If a node is successfully inserted into the document at a previous position libfyaml actually copies it, it seems, so it's necessary at that point to free the original node This might cause a few problems later but we'll see... gh-104
…trict C11 mode is enabled (which was apparently added at some point) I think I lost a lot of hair over this one... gh-104
embray
force-pushed
the
issue-104
branch
2 times, most recently
from
92f2ce1 to
0a5e2ed
Compare
but this also still isn't right either; just wanna see what happens...
Collaborator
Author
|
Hmm...still doesn't seem to like that... |
global like they were before gh-104
Collaborator
Author
|
📿 |
Collaborator
Author
|
Praise be to Allah, this seems to actually work. I think it's more sensible now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #104 -- sets up a lot of the preliminary work for writing values.
This PR by chance also exposed some new and exciting problems with the build system, so I've tried to clean that up as best I can. I think things are a little cleaned up now compared to just throwing global settings around pell-mell.