Run clang-tidy #131
Merged
Run clang-tidy #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow variables p and q in loops - allow i_keyclass macro for setting up STC types; more to follow
- I'm not fully convinced this is that much clearer as there is now some state that is maintained between different function calls, but having separate subroutines for individual steps is I think easier to manage
…o follow style: more minor tidying of style warnings
fix: a couple minor potential memory leaks also caught by tidy
clang-analyzer doesn't understand that hmap_push() is taking ownership of the allocated key
…l-terminated strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't run clang-tidy in a long time and it caught a bunch of little things we can stand to take a little more care with.
I'm still having a problem with it not suppressing warnings that bubble up from STC. Newer versions of clang-tidy have an option to ignore specific headers but my local version doesn't have this setting yet.