Improve gem loading

[n-rodriguez]

Fix wrong namespace for loggers, switch to zeitwerk to load gem and prevent this kind of issue in the future.

Thank you!

[samsonjs]

Love this change! It is a breaking change so we need to bump the major version. And I think it would be good to go through a deprecation cycle where we assign the previous constants in a minor version bump, and then remove those deprecated compatibility shims in the next major version. Will you help work on that part as well?

[n-rodriguez]

Love this change! It is a breaking change so we need to bump the major version. And I think it would be good to go through a deprecation cycle where we assign the previous constants in a minor version bump, and then remove those deprecated compatibility shims in the next major version. Will you help work on that part as well?

Thank you! But I don't think this a breaking change, rather a fixing change 😄

1. having Reporters::LoggerReporter, Reporters::ActiveSupportReporter and ParameterFilter badly namespaced was an error in the first place as it could create namespace collisions with user code
2. by looking at the doc, it seems that these classes are implementation/internal details and users should not rely on it (contrary to the other classes, which don't change)
3. assigning the previous constants will create the same namespace collisions we are fixing

#!/usr/bin/env ruby

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'
  gem 'grape_logging'
end

class Reporters
end

Reporters.new

./toto.rb:10:in '<main>': Reporters is not a class (TypeError)
/Users/nicolas/.asdf/installs/ruby/4.0.1/lib/ruby/gems/4.0.0/gems/grape_logging-3.0.0/lib/grape_logging/reporters/active_support_reporter.rb:1: previous definition of Reporters was here

[samsonjs]

Fair enough, I'm convinced. It would be strange for someone to have been referring to ::Reporters directly without going through GrapeLogging first. Technically a breaking change but maybe I'm being too conservative here.

[samsonjs]

Much cleaner! 🧼

[samsonjs]

Please add a line to changelog and then this is good to merge!

[n-rodriguez]

@samsonjs

Please add a line to changelog and then this is good to merge!

Done! Thank you!