fix: remove unreachable code path causing warning#221
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Mar 20, 2026
Merged
fix: remove unreachable code path causing warning#221zachdaniel merged 1 commit intoash-project:mainfrom
zachdaniel merged 1 commit intoash-project:mainfrom
Conversation
Remove the unreachable code path that was causing the following warning
to be shown each time the test suite was run in a project that uses
ash_sql under elixir 1.20.0-rc.3-otp-28
warning: the following clause cannot match because the previous clauses already matched all possible values:
version ->
it attempts to match on the result of:
System.get_env("ASH_VERSION")
which has the already matched type:
dynamic(nil or binary())
where "version" was given the type:
# type: dynamic(nil or binary())
# from: mix.exs:114:7
version
type warning found at:
│
114 │ version ->
│ ~
│
└─ mix.exs:114:15: AshSql.MixProject.ash_version/1
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unreachable code path that was causing the following warning to be shown each time the test suite was run in a project that uses ash_sql under elixir 1.20.0-rc.3-otp-28
warning: the following clause cannot match because the previous clauses already matched all possible values:
114 │ version ->
│ ~
│
└─ mix.exs:114:15: AshSql.MixProject.ash_version/1
Contributor checklist
Leave anything that you believe does not apply unchecked.