Fill ASCII art based on battery percentage#10
Conversation
|
Thanks for the contribution! I noticed that the get_ascii() changes now always show the battery percentage inside the ASCII art. While that works for the screenshot example, every user may not want this behavior. It would be great if you could make this optional — for example, by adding a config flag or command-line argument to enable it. By default, the feature should stay off so the existing behavior remains unchanged.Thanks for the contribution! I noticed that the get_ascii() changes (lines 180–218) now always show the battery percentage inside the ASCII art. While that works for the screenshot example, every user may not want this behavior. It would be great if you could make this optional — for example, by adding a config flag or command-line argument to enable it. By default, the feature should stay off so the existing behavior remains unchanged. |
|
Very shitty pr, so just opened a new and better one with the required behaviour |
Only made changes in the get_ascii() function, rest of the changed lines are just my nvim formatting the indentation according to it, The changed code is from line no. 180 - 218
the battery percentage inside the ascii art was given through custom data for taking the screenshot, it shows the correct one only