BEJ-5 Show admin dog delete impact preview

[shovoncse]

Summary

• Add a backend delete-impact preview for admin dog deletion counts and orphan owner/breeder warnings.
• Show deleted vs detached rows in the admin delete confirmation modal with fallback text when preview loading fails.
• Add focused DB, server, action, query, and component coverage.

Linear: https://linear.app/beagle-tietokanta/issue/BEJ-5/admin-dogs-show-delete-impact-preview-and-orphan-warnings

Tests

• pnpm --filter @beagle/web test:unit components/admin/dogs/tests/delete-dog-confirm-modal.test.tsx components/admin/dogs/tests/admin-dogs-page-client.test.tsx app/actions/admin/dogs/manage/tests/get-delete-impact.test.ts queries/admin/dogs/manage/tests/use-admin-dog-delete-impact-query.test.ts
• pnpm --filter @beagle/server test:unit admin/dogs/manage/tests/get-delete-impact.test.ts
• pnpm --filter @beagle/db test:unit admin/dogs/manage/tests/delete-impact.test.ts
• pnpm --filter @beagle/contracts typecheck
• pnpm --filter @beagle/db typecheck
• pnpm --filter @beagle/server typecheck
• pnpm --filter @beagle/web typecheck
• pnpm --filter @beagle/contracts lint
• pnpm --filter @beagle/db lint (warnings only: existing deep relative import warnings)
• pnpm --filter @beagle/server lint (warnings only: existing deep relative import/import cycle warnings)
• pnpm --filter @beagle/web lint (warning only: existing unused _trialId in app/api/trials/[trialId]/pdf/route.ts)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
beagle-db-v2	Ignored	Preview	Jun 24, 2026 4:19pm

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)

• packages/db/admin/dogs/manage/list-dogs.ts - Bug fix: changed trialResults to trialEntries
• packages/db/admin/dogs/manage/__tests__/list-dogs.test.ts - Test update for the column name fix

Previous Review Summaries (3 snapshots, latest commit e411940)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit e411940)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (24 files)

• CHANGELOG.md
• apps/web/app/actions/admin/dogs/manage/get-delete-impact.ts
• apps/web/app/actions/admin/dogs/manage/__tests__/get-delete-impact.test.ts
• apps/web/components/admin/dogs/admin-dogs-page-client.tsx
• apps/web/components/admin/dogs/delete-dog-confirm-modal.tsx
• apps/web/components/admin/dogs/__tests__/admin-dogs-page-client.test.tsx
• apps/web/components/admin/dogs/__tests__/delete-dog-confirm-modal.test.tsx
• apps/web/lib/i18n/messages/admin/dogs/modals.ts
• apps/web/queries/admin/dogs/index.ts
• apps/web/queries/admin/dogs/manage/query-keys.ts
• apps/web/queries/admin/dogs/manage/use-admin-dog-delete-impact-query.ts
• apps/web/queries/admin/dogs/manage/__tests__/use-admin-dog-delete-impact-query.test.ts
• packages/contracts/admin/dogs/manage/delete-admin-dog.ts
• packages/contracts/admin/dogs/manage/index.ts
• packages/contracts/index.ts
• packages/db/admin/dogs/manage/delete-impact.ts
• packages/db/admin/dogs/manage/__tests__/delete-impact.test.ts
• packages/db/admin/dogs/manage/index.ts
• packages/db/index.ts
• packages/server/admin/dogs/manage/get-delete-impact.ts
• packages/server/admin/dogs/manage/__tests__/get-delete-impact.test.ts
• packages/server/admin/dogs/index.ts
• packages/server/admin/index.ts
• packages/server/index.ts

Previous review (commit c932485)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	2
WARNING	0
SUGGESTION	0

Issue Details (click to expand)

CRITICAL

File	Line	Issue
apps/web/queries/admin/dogs/manage/query-keys.ts	19	adminDogDeleteImpactQueryKeyRoot declared inside adminDogColorOptionsQueryKeyRoot array, leaving it unclosed — breaks compilation
apps/web/queries/admin/dogs/manage/query-keys.ts	50	adminDogColorOptionsQueryKey() missing closing } — breaks compilation

Files Reviewed (2 files)

• apps/web/queries/admin/dogs/manage/query-keys.ts - 2 CRITICAL issues (syntax errors introduced by PR)

Fix these issues in Kilo Cloud

Previous review (commit 0c22d73)

Status: No Issues Found | Recommendation: Merge

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	0

Files Reviewed (13 files)

• CHANGELOG.md
• apps/web/app/actions/admin/dogs/manage/__tests__/get-delete-impact.test.ts
• apps/web/app/actions/admin/dogs/manage/get-delete-impact.ts
• apps/web/components/admin/dogs/__tests__/admin-dogs-page-client.test.tsx
• apps/web/components/admin/dogs/__tests__/delete-dog-confirm-modal.test.tsx
• apps/web/components/admin/dogs/admin-dogs-page-client.tsx
• apps/web/components/admin/dogs/delete-dog-confirm-modal.tsx
• apps/web/lib/i18n/messages/admin/dogs/modals.ts
• apps/web/queries/admin/dogs/index.ts
• apps/web/queries/admin/dogs/manage/__tests__/use-admin-dog-delete-impact-query.test.ts
• apps/web/queries/admin/dogs/manage/query-keys.ts
• apps/web/queries/admin/dogs/manage/use-admin-dog-delete-impact-query.ts
• packages/contracts/admin/dogs/manage/delete-admin-dog.ts
• packages/contracts/admin/dogs/manage/index.ts
• packages/contracts/index.ts
• packages/db/admin/dogs/manage/__tests__/delete-impact.test.ts
• packages/db/admin/dogs/manage/delete-impact.ts
• packages/db/admin/dogs/manage/index.ts
• packages/db/index.ts
• packages/server/admin/dogs/manage/__tests__/get-delete-impact.test.ts
• packages/server/admin/dogs/manage/get-delete-impact.ts
• packages/server/admin/dogs/index.ts
• packages/server/admin/index.ts
• packages/server/index.ts

Review Notes

• Auth guard + session check + dog ID validation correctly enforced at both server service and web action layers — no bypass possible.
• Orphan detection logic (owners and breeders left with no dogs after deletion) correctly uses every() + Map deduplication.
• Query hook staleTime: 0 + refetchOnWindowFocus: false is appropriate for a one-shot modal-triggered read; consistent with similar profile query (useAdminDogProfileQuery).
• enabled prop in useAdminDogDeleteImpactQuery is redundant with the caller's control but does not cause incorrect behavior.
• Tests cover all layers: db mock, service mock, action mock, query hook config, component rendering with impact data, and component fallback rendering.

---

_{Reviewed by laguna-m.1-20260312:free · Input: 357.6K · Output: 4.3K · Cached: 162.5K}

[asku1990]

I rebased this up to develop and fixed conflicts.
Now i'm going to test this.