Skip to content

Develop to main#305

Merged
asku1990 merged 16 commits into
mainfrom
develop
Jun 24, 2026
Merged

Develop to main#305
asku1990 merged 16 commits into
mainfrom
develop

Conversation

@asku1990

@asku1990 asku1990 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Dog color support and orphan varnings when dog is deleted.

closes bej-107
closes bej-111
closes bej-5

shovoncse and others added 12 commits June 17, 2026 13:17
…data-modelimport-strategy-to-preserve-dog

Hide breeder fields from admin dog UI
Add dog color storage, legacy import mapping, public profile display,
and admin form color selection backed by lookup data.

Files:
- CHANGELOG.md
- apps/web/app/actions/admin/dogs/lookups/get-admin-dog-color-options.ts
- apps/web/components/admin/dogs/admin-dogs-page-client.tsx
- apps/web/components/admin/dogs/dog-form-modal.tsx
- apps/web/components/admin/dogs/internal/dog-form-metadata-section.tsx
- apps/web/components/beagle-dog-profile/dog-profile-details-card.tsx
- apps/web/lib/admin/dogs/manage/dog-form-mappers.ts
- apps/web/lib/admin/dogs/manage/dog-mutation-flow.ts
- apps/web/queries/admin/dogs/lookups/use-admin-dog-color-options-query.ts
- docs/features/admin-dog-management.md
- docs/features/beagle-dog-profile.md
- docs/features/schema/schema.md
- docs/legacy-import/phase1.md
- packages/contracts/admin/dogs/lookups/lookup-options.ts
- packages/contracts/admin/dogs/manage/admin-dogs-list.ts
- packages/contracts/admin/dogs/manage/create-admin-dog.ts
- packages/contracts/admin/dogs/manage/update-admin-dog.ts
- packages/db/admin/dogs/lookups/list-color-options.ts
- packages/db/prisma/migrations/20260506120000_add_dog_colors/migration.sql
- packages/db/prisma/schema.prisma
- packages/server/admin/dogs/lookups/list-color-options.ts
- packages/server/admin/dogs/manage/create-dog.ts
- packages/server/admin/dogs/manage/update-dog.ts
- packages/server/imports/phase1/run-legacy-phase1.ts
- related tests and index exports

ref bej-107
  - cover the admin dog color lookup service, action wrapper, and query hook
  - verify auth, success, and failure branches so the coverage gate passes

ref bej-107
  Seed and expose a canonical dog color catalog with status metadata, use it for
  admin selection and profile display, and preserve legacy hidden colors during
  updates and phase 1 import.

ref bej-107
  Replace the React Query Server Action path with a canonical admin API route,
  keep the server use case as the source of business logic, and remove the now-
  unused color lookup action.

  Files:
  - apps/web/app/actions/admin/dogs/lookups/__tests__/get-admin-dog-color-options.test.ts
  - apps/web/app/actions/admin/dogs/lookups/get-admin-dog-color-options.ts
  - apps/web/app/api/admin/dogs/lookups/colors/__tests__/route.test.ts
  - apps/web/app/api/admin/dogs/lookups/colors/route.ts
  - apps/web/queries/admin/dogs/lookups/__tests__/use-admin-dog-color-options-query.test.ts
  - apps/web/queries/admin/dogs/lookups/use-admin-dog-color-options-query.ts
  - packages/api-client/admin/dogs/__tests__/admin-dogs.test.ts
  - packages/api-client/admin/dogs/create-admin-dogs-api-client.ts
  - packages/api-client/admin/dogs/index.ts
  - packages/api-client/admin/dogs/list-admin-dog-color-options.ts

ref bej-107
…r-details

feat(dogs): add color lookup support
…elete-impact-preview-and-orphan-warnings

BEJ-5 Show admin dog delete impact preview
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
beagle-db-v2 Ready Ready Preview, Comment Jun 24, 2026 5:40pm

@kilo-code-bot

kilo-code-bot Bot commented Jun 24, 2026

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 0
SUGGESTION 0
Issue Details (click to expand)

CRITICAL

File Line Issue
apps/web/components/admin/dogs/__tests__/admin-dogs-page-client.test.tsx 311-312 Missing required property colorCode in deleteTarget mock object. The AdminDogRecord type requires `colorCode: number
Files Reviewed (24 files)
  • apps/web/components/admin/dogs/__tests__/admin-dogs-page-client.test.tsx - 1 issue
  • apps/web/components/admin/dogs/__tests__/delete-dog-confirm-modal.test.tsx - OK
  • apps/web/components/admin/dogs/delete-dog-confirm-modal.tsx - OK
  • apps/web/app/actions/admin/dogs/manage/__tests__/get-delete-impact.test.ts - OK
  • apps/web/app/actions/admin/dogs/manage/get-delete-impact.ts - OK
  • apps/web/queries/admin/dogs/manage/__tests__/use-admin-dog-delete-impact-query.test.ts - OK
  • apps/web/queries/admin/dogs/manage/use-admin-dog-delete-impact-query.ts - OK
  • apps/web/queries/admin/dogs/manage/query-keys.ts - OK (fix applied in PATCH 9/9)
  • packages/contracts/admin/dogs/manage/delete-admin-dog.ts - OK
  • packages/contracts/admin/dogs/manage/index.ts - OK
  • packages/contracts/index.ts - OK
  • packages/db/admin/dogs/manage/__tests__/delete-impact.test.ts - OK
  • packages/db/admin/dogs/manage/delete-impact.ts - OK
  • packages/db/admin/dogs/manage/index.ts - OK
  • packages/db/index.ts - OK
  • packages/server/admin/dogs/index.ts - OK
  • packages/server/admin/dogs/manage/__tests__/get-delete-impact.test.ts - OK
  • packages/server/admin/dogs/manage/get-delete-impact.ts - OK
  • packages/server/admin/index.ts - OK
  • packages/server/index.ts - OK
  • apps/web/components/admin/dogs/types.ts - OK (type definition is correct)
  • packages/db/prisma/migrations/20260623120000_add_dog_color_status/migration.sql - OK
  • packages/db/prisma/migrations/20260506120000_add_dog_colors/migration.sql - OK
  • packages/db/dogs/colors/definitions.ts - OK
  • Plus additional files in patches 1-8 (color support, API routes, etc.)

Reviewed by laguna-m.1-20260312:free · Input: 5.2M · Output: 18K · Cached: 5.8M

@asku1990 asku1990 merged commit 3cf1128 into main Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants