fix(nix): include internal/web/assets in flake fileset for go:embed#142
Merged
Conversation
The fileset union only included .go and .sql files, so the embedded assets directory (HTML templates, htmx.min.js, app.css, VERSION) was absent from the Nix build sandbox. The go:embed directive in routes.go then failed with 'pattern assets: no matching files found'. Also update CLAUDE.md repository layout to reflect current package structure (app, store, inventory, eventbus, web) and remove stale references to the deleted database/ and migrate/ packages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./internal/web/assetsto thelib.fileset.unionslist inflake.nixCLAUDE.mdrepository layout to reflect current package structureRoot Cause
The Nix build uses an allowlist fileset (
lib.fileset.unions) that only included.goand.sqlfiles. Theinternal/web/assetsdirectory — containing HTML templates,htmx.min.js,app.css, andVERSION— was absent from the build sandbox, causing the//go:embed assetsdirective inroutes.goto fail:Fix
+ ./internal/web/assetsThis is the same pattern already used for SQL migrations — the entire directory is included rather than a file-extension filter, since the assets include
.html,.js,.css, and extension-less files.Test Plan
nix buildsucceedsmise run testpasses (547 tests)