SOLUTION: Reduan Senoun & Víctor García-Vao #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .img-thumbnail { | ||
| padding: 0; | ||
| border: none; | ||
| width: 100%; |
There was a problem hiding this comment.
We can also change the height property of the images to make everything have the same size.
src/js/main.js
Outdated
| "https://pixabay.com/api/?key=27437216-9ddae61d97237ec9e5fc37f36&q=nature&image_type=photo&category=nature" | ||
| ); | ||
|
|
||
| Posts.then((response) => response.json()) |
There was a problem hiding this comment.
I think that these methods related to making requests to the API can be added in another .js, just like other functions in another .js for example utils.js
|
|
||
| const createElement = (element) => { | ||
| return document.createElement(element); | ||
| }; |
There was a problem hiding this comment.
| @@ -0,0 +1,95 @@ | |||
|
|
|||
There was a problem hiding this comment.
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "server": "json-server --watch ./src/data/db.json", | ||
| "start": "concurrently \"npm run json_server\" \"npm run server\" " |
There was a problem hiding this comment.
added 11 commits
May 17, 2022 14:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.