Reduce code duplication by extracting shared helpers#2
Open
PeterKnego wants to merge 1 commit into
Open
Conversation
PeterKnego
commented
Feb 24, 2026
PeterKnego
commented
- catalog: extract js_property_name() for quoting JS identifiers
- client: merge identical Http/Sse match arms; extract make_params closure
- main: extract format_transport_info(), print_server_saved(); merge parse_headers/parse_envs into parse_key_value()
- server: extract user_config_mtime() helper
- transpile: extract fmt_errors() to unify error-formatting pattern
- catalog: extract js_property_name() for quoting JS identifiers - client: merge identical Http/Sse match arms; extract make_params closure - main: extract format_transport_info(), print_server_saved(); merge parse_headers/parse_envs into parse_key_value() - server: extract user_config_mtime() helper - transpile: extract fmt_errors() to unify error-formatting pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.