Conversation
- Update phpunit.xml.dist schema to PHPUnit 10.5 - Remove deprecated processUncoveredFiles attribute - Remove obsolete SYMFONY_PHPUNIT_VERSION env vars - Override testValidValues/testInvalidValues in EntityValidatorTest and PostalValidatorTest to skip when data providers are empty (PHPUnit 10 now errors on empty data providers instead of silently skipping) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…h phpunit Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add phpcs:ignore for PHP 8.3 typed constants in BelgianEnterpriseNumber - Fix line length in EntityValidatorTest and PostalValidatorTest - Add docblocks to FrenchSiren/FrenchSiret constructors for PHPStan - Remove now-fixed entries from phpstan baseline Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously set via simple-phpunit env, now set in phpunit.xml.dist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fails only on deprecations from our own code, not from dependencies. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PHP_CodeSniffer 3.9+ handles PHP 8.3 typed constants correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
❌ The last analysis has failed. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phpunit.xml.distto use PHPUnit 10 schemaprocessUncoveredFilesattribute and obsolete Symfony env vars<source>elementEntityValidatorTestandPostalValidatorTest: PHPUnit 10 now errors on empty data providers (previously they were silently skipped in PHPUnit 9). AddstestValidValues/testInvalidValuesoverrides that callmarkTestSkipped()in these classes.Test plan
🤖 Generated with Claude Code