Add regime in spectrum duplicate check in find_spectra#236
Add regime in spectrum duplicate check in find_spectra#236kelle merged 3 commits intoastrodbtoolkit:mainfrom
Conversation
kelle
left a comment
There was a problem hiding this comment.
Please try to add a test which tests this new functionality.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 71.32% 72.38% +1.06%
==========================================
Files 19 19
Lines 1653 1673 +20
Branches 210 211 +1
==========================================
+ Hits 1179 1211 +32
+ Misses 387 380 -7
+ Partials 87 82 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
(Notice that the code coverage report is also not happy because the new code isn't being tested.) |
|
Added test coverage to verify the regime duplicate check in |
kelle
left a comment
There was a problem hiding this comment.
Minor tweak to docstring. otherwise, looks great! (Assuming tests pass.)
Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
The
find_spectra()function includes source, mode, observation_date, and reference but regime is not used in the duplicate check when ingesting spectra.This PR update adds regime to prevent ingesting spectra that are identical in all fields except regime.