FIX: clear stale _ex before each execute_stream call#751
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 79.54% 79.57% +0.02%
==========================================
Files 91 91
Lines 10293 10294 +1
==========================================
+ Hits 8188 8191 +3
+ Misses 2105 2103 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b836762 to
060a803
Compare
060a803 to
b3910bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_exwas never cleared betweenexecute_streamcalls, so there was the potential that a stale HTTP error from a previous failed request could mask VOTable parse errors on a later successful one.Fix
Reset
self._ex = Noneat the start ofexecute_stream