fix: cleans up plugin event listeners on update and unmount properly#1272
Open
Ishita-190 wants to merge 5 commits intoasyncapi:masterfrom
Open
fix: cleans up plugin event listeners on update and unmount properly#1272Ishita-190 wants to merge 5 commits intoasyncapi:masterfrom
Ishita-190 wants to merge 5 commits intoasyncapi:masterfrom
Conversation
Ishita-190
requested review from
AceTheCreator,
asyncapi-bot-eve,
fmvilas and
magicmatatjahu
as code owners
AceTheCreator
requested changes
Apr 28, 2026
Member
AceTheCreator
left a comment
AceTheCreator
left a comment
There was a problem hiding this comment.
Hey @Ishita-190
Can you fix your failing tests? Once done, i'll give it a review
|
AceTheCreator
requested changes
May 2, 2026
| } | ||
|
|
||
| class AsyncApiComponent extends Component<AsyncApiProps, AsyncAPIState> { | ||
| componentWillUnmount() { |
Member
There was a problem hiding this comment.
I find the lifecycle placement hard to read. I don't think componentWillUnmount should be at the top-level
| this.props.onPluginEvent!(eventName, data); | ||
| }; | ||
| } | ||
| private eventHandlers = new Map<string, (data: unknown) => void>(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
eventHandlersMap which will then be reused for bothpm.onandpm.offcomponentWillUnmounttoAsyncApiComponentfor proper event listener cleanup.verified this using a test, it's working properly :
Related issue(s)
Fixes #1235