test: add test cases for recursion detection#1273
Open
KUNDAN1334 wants to merge 9 commits intoasyncapi:masterfrom
Open
test: add test cases for recursion detection#1273KUNDAN1334 wants to merge 9 commits intoasyncapi:masterfrom
KUNDAN1334 wants to merge 9 commits intoasyncapi:masterfrom
Conversation
Collaborator
|
@KUNDAN1334 nice work, the tests are passing now, |
Contributor
Author
|
@catosaurusrex2003 Thanks for the review! I'll fix the linting issues shortly. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR adds test cases for recursion detection in
jsonFieldToSchemaas requested in #1242.The existing tests in
library/src/helpers/__tests__/schema.test.tscovered basic transformations but had no coverage for recursion scenarios introduced in #1101 and #1241.Test cases added inside
describe('.jsonToSchema'):Related issue(s)
Closes #1242
Note: The tests should NOT throw when the same object is referenced in two sibling branches and should NOT throw when the same object appears in multiple array positions are expected to fail on current master until #1241 is merged. They are intentionally written to validate the fix introduced in #1241.