add function to compute emittance from beam#1065
Open
swhite2401 wants to merge 2 commits intomasterfrom
Open
Conversation
lfarv
reviewed
Mar 29, 2026
| if sigma_mat is not None: | ||
| msg = "beam provided, sigma_matrix ignored in emittance calculation" | ||
| warn(AtWarning(msg)) | ||
| sigma_mat = sigma_matrix(beam=beam.copy()) |
Contributor
There was a problem hiding this comment.
The reveals an inconvenient feature of sigma_matrix. It would be better to replace at line 129:
beam -= orbit.reshape((6, 1))with
beam = beam - orbit.reshape((6, 1))Which would avoid that sigma_matrix modifies its input. And avoid the copy() here.
Contributor
|
Apart from that, this looks nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a function to compute the emittance of a particule distribution based on the sigma_matrix analysis.