Skip to content

Conversation

@justinxu421
Copy link
Contributor

@justinxu421 justinxu421 commented Oct 8, 2025

Replace Bun with Node.js as the runtime for development and testing.

Key Changes

  • Runtime: Switch from Bun to Node.js for running tests and scripts
  • Dependency management: Replace bun.lock with package-lock.json and update engine requirements to specify Node.js ≥22.0.0 only
  • Scripts: Update all package.json scripts to use npm/node commands instead of bun
  • Documentation: Update RELEASE.md to reference npm commands throughout

Technical Impact

This change improves compatibility with standard Node.js tooling and aligns with changes made in the augment-agent repository (see augment-agent PR #9).

Testing

  • ✅ Package installation successful with npm
  • ✅ All documentation updated
  • ✅ Lock file generated correctly
  • ✅ Format check passes with npm

- Replace bun with npm/node in package.json scripts
- Update RELEASE.md to reference npm commands throughout
- Remove bun.lock and add package-lock.json
- Remove bun engine requirement from package.json

This change improves compatibility with standard Node.js tooling
and aligns with the augment-agent repository changes.
Copy link

@augment-app-staging augment-app-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the migration to Node.js; the changes appear consistent and focused. I left a couple notes about a documentation inconsistency referencing a non-existent script.


```bash
bun run typecheck
npm run typecheck

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step references npm run typecheck, but package.json does not define a typecheck script, so it will fail. Consider aligning the docs with the available scripts (related note also appears later in this file).

🤖 React with 👍 or 👎 to let us know if the comment was useful.

**Type check failures:**

- Run `bun run typecheck` locally to check for TypeScript errors
- Run `npm run typecheck` locally to check for TypeScript errors

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also references npm run typecheck, but there is no typecheck script in package.json (related to the earlier comment in this file). You could update the docs or add the missing script to avoid confusion.

🤖 React with 👍 or 👎 to let us know if the comment was useful.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The changes to package.json, RELEASE.md, and lock files look good. However, the Bun-to-Node.js migration is incomplete - there are critical GitHub Actions workflows that still reference Bun and will fail with the current changes.

Critical Issues Found

1. .github/workflows/format-check.yml still uses Bun

This workflow needs to be updated to use Node.js:

Lines 19-28 need updating:

# Current (uses Bun)
- name: Setup Bun
  uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
  with:
    bun-version: latest

- name: Install dependencies
  run: bun install --frozen-lockfile

- name: Check formatting
  run: bun run format:check

Should be:

- name: Setup Node.js
  uses: actions/setup-node@v4
  with:
    node-version: '22'

- name: Install dependencies
  run: npm ci

- name: Check formatting
  run: npm run format:check

Line 33 error message:

# Current
echo "❌ Files are not properly formatted. Run 'bun run format' to fix."

# Should be
echo "❌ Files are not properly formatted. Run 'npm run format' to fix."

2. .github/workflows/release.yml still uses Bun

Lines 23-29 need updating:

# Current (uses Bun)
- name: Setup Bun
  uses: oven-sh/setup-bun@735343b667d3e6f658f44d0eca948eb6282f2b76 # v2.0.2
  with:
    bun-version: latest

- name: Install dependencies
  run: bun install

Should be:

- name: Setup Node.js
  uses: actions/setup-node@v4
  with:
    node-version: '22'

- name: Install dependencies
  run: npm ci

3. .prettierignore references obsolete Bun lock files

Lines 60-61 should be removed:

bun.lock
bun.lockb

These are no longer relevant since the project now uses package-lock.json.

Recommendation

These workflow files need to be updated in this PR to complete the migration. Without these changes, CI/CD pipelines will fail because they'll try to use Bun commands with a Node.js-only setup.


🤖 Automated review complete. Please react with 👍 or 👎 on the individual review comments to provide feedback on their usefulness.

@justinxu421 justinxu421 marked this pull request as draft October 8, 2025 22:31
@justinxu421 justinxu421 force-pushed the replace-bun-with-node branch from 8cb4c1d to 84262b2 Compare October 8, 2025 22:32
@justinxu421 justinxu421 closed this Oct 8, 2025
@justinxu421 justinxu421 deleted the replace-bun-with-node branch October 9, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants