Skip to content

Conversation

@Meyazhagan
Copy link
Contributor

closes: #2744

Description

Improve UX of error msg

before:
accepts 1 arg(s), received 0

after:
missing required argument: 'revision'

Testing

References

@Meyazhagan Meyazhagan requested a review from a team as a code owner December 9, 2025 17:47
@github-actions github-actions bot added the area/cli Affects the command line label Dec 9, 2025
@Meyazhagan Meyazhagan changed the title fix (migrate): error message for missing revision argument fix (migrate): Improve UX of error msg Dec 9, 2025
miparnisari
miparnisari previously approved these changes Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.69%. Comparing base (74a56f1) to head (aa5db73).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/migrate.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
- Coverage   77.70%   77.69%   -0.01%     
==========================================
  Files         472      472              
  Lines       49722    49723       +1     
==========================================
- Hits        38633    38628       -5     
- Misses       8234     8241       +7     
+ Partials     2855     2854       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tstirrat15
Copy link
Contributor

@Meyazhagan it looks like you've got some lint failures - can you have a look at those and submit an update?

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Dec 10, 2025
@Meyazhagan Meyazhagan force-pushed the ux-migrate-err-msg branch 2 times, most recently from 1d8ceff to dc88702 Compare December 10, 2025 16:16
@github-actions github-actions bot removed the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Dec 10, 2025
@Meyazhagan
Copy link
Contributor Author

@tstirrat15 fixed the lint failures. please have a look!
it look like unit test is failing, but it doesn't seems related to this change. lets re-run it an see

@miparnisari miparnisari enabled auto-merge January 2, 2026 22:41
@miparnisari miparnisari added this pull request to the merge queue Jan 2, 2026
Merged via the queue into authzed:main with commit cec0f49 Jan 2, 2026
44 of 45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/cli Affects the command line

Projects

None yet

Development

Successfully merging this pull request may close these issues.

improve UX of "migrate" command

3 participants