Skip to content

Conversation

@ivanauth
Copy link
Contributor

@ivanauth ivanauth commented Dec 19, 2025

Summary

  • Extract backupCreateImpl with injectable client and ProgressTracker interface for testability
  • Harden retry logic (error checks, max 10 retries)
  • Remove legacy Serverless backup path
  • Add --prefix-filter and --rewrite-legacy flags

Resolves #569

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 51.01010% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.82%. Comparing base (ec981d0) to head (7a02c9f).

Files with missing lines Patch % Lines
internal/cmd/backup.go 51.01% 73 Missing and 24 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   42.48%   42.82%   +0.34%     
==========================================
  Files          38       38              
  Lines        5030     5083      +53     
==========================================
+ Hits         2137     2177      +40     
+ Misses       2638     2634       -4     
- Partials      255      272      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Resolves authzed#569

Signed-off-by: ivanauth <ivan@authzed.com>
@ivanauth ivanauth force-pushed the fix/issue-569-refactor-backup-create branch from 8437759 to 7a02c9f Compare January 24, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize backupCreate code and refactor tests accordingly

2 participants