fix: reentrancy.Guard() panic on static call#284
Merged
Conversation
StephenButtolph
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Could cause a panic on a live chain. This isn't in production anywhere so no upgrade is required.
How this works
Checks for a read-only environment before using the state DB, which would otherwise result in a nil-pointer dereference.
This actually points to a deeper code smell about
vm.PrecompileEnvironmentin that it's too easy to misuse theStateDB()method. It should probably have its return signature changed to(*state.StateDB, error)and returnvm.ErrWriteProtectioninstead of anilDB when in read-only contexts.How this was tested
Extended existing integration test to perform a static call to the guarded precompile, asserting a
vm.ErrWriteProtection.