Merged
Conversation
- Bump required_ruby_version to >= 3.3.11 - Update mise config to Ruby 3.4.7 - Overhaul CI workflow: target master branch, matrix over 3.3/3.4/4.0, run rspec and rubocop separately Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Bump minitest to 6.0.2 (removes ruby < 4.0 constraint) and activesupport to 8.1.3 (declares bigdecimal explicitly, required since Ruby 3.4 removed it from default gems) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Ruby 4.0 removed ostruct from default gems; declare it explicitly since activesupport requires it at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace rubocop/rubocop-rspec/rubocop-rake with standard (>= 1.35.1) - Add .standard.yml disabling Lint/ConstantDefinitionInBlock in specs - Remove .rubocop.yml; update CI and bin/ci to use standardrb - Add benchmark and racc as explicit dev deps for Ruby 4 compatibility - Fix copy-paste bug in specs using wrong class name (SingleInvalidCriteriaClass) - Apply standard style fixes across lib and spec files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validates_with,prepares_with,done_criteria) — previously passed the block as a positional arg instead of forwarding it.mise.tomlto 3.4.7 andrequired_ruby_versionto>= 3.3.11bin/ciscript to run rspec + standardrb locally against Ruby 3.3, 3.4, and 4.0 via misebenchmark,racc,ostructafter_initcallbacks, andcheckwith multiple callbacksdocs/DEVELOPERS.md,AGENTS.md) and linked from READMEKey Files
lib/storyteller.rb— block forwarding fix.github/workflows/main.yml— CI matrix over Ruby 3.3, 3.4, 4.0 with standardrbbin/ci— local CI script.standard.yml— StandardRB configstoryteller.gemspec— updated Ruby version requirement and depsspec/storyteller_spec.rb— bug fix + new coverageTest plan
bin/cipasses on Ruby 3.3.11, 3.4.7, and 4.0.x (24 examples, 0 failures, standardrb clean)