fix: avoid sync checkpoint race #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move completion event signaling to after the execution state is updated from the checkpoint response. This prevents a waiting user thread from running the second status check before new operations are added, which could lead to a duplicate START and stalled checkpoint thread. This preserves the existing checkpoint API semantics while closing the race window between completion signaling and state refresh.
yaythomas
approved these changes
Jan 4, 2026
Member
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
thank you so much for a great fix! welcome to dex!
Contributor
Author
|
thank you for the quick review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #245
Description of changes:
Move completion event signaling to after execution state is updated from the checkpoint response.
Prevent a waiting user thread from running the second status check before new operations are added, avoiding duplicate STARTs and a stalled checkpoint thread.
Preserve existing checkpoint API semantics while closing the race window between completion signaling and state refresh.
Tests:
Fixes [Bug]: Duplicate START from synchronous checkpoint race causes map to stall and timeout #245
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.