feat: add serdes for map and parallel #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaythomas
approved these changes
Sep 21, 2025
Member
yaythomas
left a comment
yaythomas
left a comment
There was a problem hiding this comment.
separate PR possibly, but would be good to add e2e/serdes_int_test.py, to test serdes works end-to-end for each operation (step/parallel/map/run-in-child etc) in the way that a client would actually use it (e.g define a @durable_step with a serdes, run it from a @durable_handler, similarly for parallel.)
the current unit test added here test_parallel_handler_with_serdes hard-codes a serialise into the test, it would be
Contributor
Author
|
Sounds good, I will add e2e tests in a follow up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note that the checks are failing die to this new hatch issue: pypa/hatch#2050
hatch run types:checkran successfully locally.Also, because we do not call checkpoint during map & parallel, I only pass Serdes through the config and test them with customized caller functoin.