Avoid infinite log resending if exceptions happen during the log-sending process#219
Avoid infinite log resending if exceptions happen during the log-sending process#219
Conversation
set auth region when service url is used
* drop logs if exceptions happen * avoid 24 hours rule * remove test code * combine exceptions
|
do we know if this issue is still happening in the latest version @amidofu |
|
@amidofu are you able to confirm if this issue is still happening? |
|
@afroz429 I think you can test it by adding an event like to here and see if thank you |
|
I was able to reproduce it with the latest using AWS.Logger;
using AWS.Logger.Core;
var config = new AWSLoggerConfig
{
LogGroup = "test-infinite-resend",
Region = "us-east-1",
LibraryLogFileName = "errors.log"
};
new AWSLoggerCore(config, "Repro").AddMessage("trigger");
Console.WriteLine("Watching errors.log for repeated failures...");
await Task.Delay(30000);
Console.WriteLine(File.ReadAllText("errors.log"));Having said that, I do think the Once you address the merge conflicts we can take a look again. |
|
@dscpinheiro |
Issue #, if available:
Description of changes:
For 1., we did this because we observed that our log batch causes the over 24 hours spanning problem
and since the monitor is not stopped, it just resends the log batch forever.
For 2., we did this because we got a problem with the auth region setup
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.