[PCUI][Bug Fix] Fix access tokens leaking to CloudWatch logs#453
Merged
[PCUI][Bug Fix] Fix access tokens leaking to CloudWatch logs#453
Conversation
gmarciani
reviewed
Mar 16, 2026
api/logging/http_info.py
Outdated
| _headers.pop('Cookie', None) | ||
| _headers.pop('X-CSRF-Token', None) | ||
| for header in SENSITIVE_HEADERS: | ||
| _headers.pop(header, None) |
Collaborator
There was a problem hiding this comment.
This removal is case sensitive, but HTTP are case insensitive.
I suggest to remove in a case insensitive fashion.
gmarciani
reviewed
Mar 16, 2026
| 'Cookie', | ||
| 'Set-Cookie', | ||
| 'X-CSRF-Token', | ||
| 'Authorization', |
Collaborator
There was a problem hiding this comment.
Good catch to exclude the authorization header as well!
gmarciani
reviewed
Mar 16, 2026
| headers = { | ||
| 'Content-Type': 'application/json', | ||
| 'Cookie': 'accessToken=eyJsecrettoken', | ||
| 'Set-Cookie': 'accessToken=eyJsecrettoken; Secure; HttpOnly', |
Collaborator
There was a problem hiding this comment.
If you agreeew with my comment on case insensitivity, then let;s adapt the test to verify that ther rmeoval is canse insensitive.
…fy with mixed-case header names.
hehe7318
force-pushed
the
wip/fix-sensitive-data-leak
branch
from
247c71b to
6d47700
Compare
gmarciani
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug that response headers contains Set-Cookie (with access tokens) and Authorization were not filtered before logging, exposing sensitive credentials in CloudWatch.
Changes
How Has This Been Tested?
PR Quality Checklist
react-i18nextlibrary (useTranslation hook and/or Trans component), see an example herenpm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.