feat: isolate async handler execution on dedicated worker event loop#273
Open
siwachabhi wants to merge 1 commit intomainfrom
Open
feat: isolate async handler execution on dedicated worker event loop#273siwachabhi wants to merge 1 commit intomainfrom
siwachabhi wants to merge 1 commit intomainfrom
Conversation
Async handlers that contain blocking calls (e.g. time.sleep, synchronous HTTP requests) previously ran on the main uvicorn event loop, freezing /ping health checks and causing container termination. This introduces a dedicated persistent worker event loop in a background thread that isolates all handler execution from the main loop. Three-way handler dispatch: - Async generators: bridged to sync generators via queue.Queue on worker loop - Regular async: run_coroutine_threadsafe + wrap_future on worker loop - Sync: run_in_threadpool (starlette thread pool) Context propagation uses contextvars.copy_context() with the Django asgiref _restore_context pattern for Python 3.10+ compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.sleep, synchronous HTTP) previously froze/pinghealth checks, causing container termination — this fix ensures/pingalways responds promptlyqueue.Queue, regular async viarun_coroutine_threadsafe, sync viarun_in_threadpoolcontextvarsacross event loop boundaries usingcopy_context()+ Django asgiref_restore_contextpattern (Python 3.10+ compatible)Test plan
TestWorkerLoopInvocationcovering:/pingcreate_tasksurvives handler returnfunctools.partialand callable class dispatchHEALTHY_BUSYping status during background taskstest_async_handler_runs_on_worker_loopto assert worker thread isolation