Fix default icon for no-type vertices#1781
Open
P-r-e-m-i-u-m wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1779.
This updates the graph style preferences so the synthetic
No Typevertex type gets the same default vertex styling as schema-backed types. That gives blank nodes without a schema type a generated Cytoscape background image, matching the default icon shown in the details panel.I also added a regression test for the no-type node style selector.
Verification
I also ran the full Vitest suite locally. The touched GraphViewer test passed, but the full run has unrelated Windows/environment failures: path assertions expecting POSIX separators, missing openssl, shell redirects failing because the workspace path contains spaces, and locale-specific number grouping under en-IN.