I/P: Fix heap copy-back failing on large remote builds#197
Open
hanno-becker wants to merge 1 commit intomainfrom
Open
I/P: Fix heap copy-back failing on large remote builds#197hanno-becker wants to merge 1 commit intomainfrom
hanno-becker wants to merge 1 commit intomainfrom
Conversation
hanno-becker
force-pushed
the
ip_heap_copy_back
branch
from
2f97f0b to
cc807e8
Compare
copy_heap_back() ran after cleanup_all() which tears down the SSH master connection. The subsequent rsync had to establish a new connection and was subject to a hard 300s timeout — insufficient for large heaps. On timeout, the proxy still exited rc=0, causing Isabelle to fail with "No such file or directory" on the missing local heap. Fix: run copy_heap_back() inside the finally block before cleanup, so it reuses the live SSH master. Remove the fixed timeout, add progress output, and exit rc=2 on copy failure so Isabelle sees a proper error. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
force-pushed
the
ip_heap_copy_back
branch
from
cc807e8 to
11acdd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy_heap_back() ran after cleanup_all() which tears down the SSH master connection. The subsequent rsync had to establish a new connection and was subject to a hard 300s timeout — insufficient for large heaps. On timeout, the proxy still exited rc=0, causing Isabelle to fail with "No such file or directory" on the missing local heap.
Fix: run copy_heap_back() inside the finally block before cleanup, so it reuses the live SSH master. Remove the fixed timeout, add progress output, and exit rc=2 on copy failure so Isabelle sees a proper error.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.