fix: use sys.stdout.write for thread-safe output in StdoutSink#140
Open
jaheyy wants to merge 1 commit intoawslabs:masterfrom
Open
fix: use sys.stdout.write for thread-safe output in StdoutSink#140jaheyy wants to merge 1 commit intoawslabs:masterfrom
jaheyy wants to merge 1 commit intoawslabs:masterfrom
Conversation
Replace print() with sys.stdout.write() to prevent interleaved output in multi-threaded environments. print() makes two separate write calls (content + newline) which can be interrupted between threads, while sys.stdout.write() with an appended newline issues a single call.
seoberha
approved these changes
Mar 14, 2026
Himtanaya
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #139
Replace
print(serialized_content)withsys.stdout.write(serialized_content + "\n"inStdoutSinkto prevent interleaved output in multi-threaded environments.sys.stdout.write(serialized_content + "\n")issues a single write call, which is atomic under CPython's GIL.Verification
Tested with a repro script: