chore: upgrade dependencies / migrate to ESM#113
Open
dirkluijk wants to merge 2 commits intoaxe-me:mainfrom
Open
chore: upgrade dependencies / migrate to ESM#113dirkluijk wants to merge 2 commits intoaxe-me:mainfrom
dirkluijk wants to merge 2 commits intoaxe-me:mainfrom
Conversation
Owner
|
Hi Dirk, thanks for your contribution! I will take some time to review it soon. Not sure if I should set the default to esm format, since it's a breaking change, that can break everyone's repo. I have to think about this. |
Author
|
Yeah, I falsely assumed one can import ESM from CommonJS. Although, this does actually work when you use a build tool for your project. Personally I try to advocate ESM, since it is the standard and supported by both Node.js and other runtimes/browsers. But I agree this is a breaking change. Of course in this case it would only affect your Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #112, I took it a bit further.
Since I wasn't directly able to get everything to work locally, I did some rework and applied the following changes:
tsconfigsetup a bit with some of the recommendation from this cheat sheet and this articleI also tested all the example projects and they seem to work fine. All that now remains is to publish a new version to NPM.