This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Open
Conversation
Miiike89
commented
Jun 18, 2020
Miiike89
commented
- enables the User to register new operations, which can be parsed by Parser
Contributor
|
@Miiike89 please, add some unit tests |
|
|
||
| def register_operation(self, token, priority, index, func): | ||
|
|
||
| if token not in self.ops1 or token not in self.ops1: |
There was a problem hiding this comment.
um.... this seems wrong... same check of ops1 twice? And not checking ops ?
And then adding it to yet another called ops2?
Author
There was a problem hiding this comment.
Yeah, you guys are right. It worked for my simple cases, but indeed there is a lack of errorhandling and unittests. I'am sorry, about that.
Unfortunately I'am currently quite swamped at work and won´t be able to fix this right away. You guys have to give me some time, please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.