Fix silent inf/NaN from zero-coverage control genes#12
Merged
dlopez-bioinfo merged 1 commit intoFeb 20, 2026
Merged
Conversation
When a BAM has no reads in a control gene, the division by zero produced silent inf/NaN that could corrupt the entire batch. Now: warn to stderr, exclude bad samples from zmean_k, and explicitly set affected sample results to NaN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.wherezmean_kso healthy samples in the same batch are not corruptedpi_ij,theta_i,z_ik) to NaN for affected samplesCloses #11
Test plan
python -m unittest discover -v smaca/)flake8cleantest_zero_coverage_gene_warningvalidates affected sample gets NaN and healthy sample gets finite results