fix(ui): keep Ask AI input visible after responses#1035
Merged
Conversation
Long completed responses caused the h-full chat flex item to retain its automatic minimum height, pushing the follow-up composer below the sidebar viewport. Let the panel consume the remaining flex space with min-h-0 so only the message area scrolls.
backnotprop
approved these changes
Jul 11, 2026
|
|
||
| return ( | ||
| <div className="flex flex-col h-full"> | ||
| <div className="flex flex-col flex-1 min-h-0"> |
Owner
There was a problem hiding this comment.
[praise] testing this review from something new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h-fullsizing with a boundedflex-1 min-h-0layoutRoot cause
The chat root was a shrinking flex child with
h-fulland an automatic minimum height. While the short streaming state could shrink beneath the sidebar header, a sufficiently long completed response made the automatic minimum height retain the full panel height. The header plus that full-height child pushed the provider bar and textarea below the viewport.Verification
bun run --cwd packages/ui typecheckbun run --cwd apps/review build && bun run build:hookA 10-second headed-Chrome proof was recorded locally as
artifacts/ask-ai-input-fix-proof.mp4(kept out of git to avoid committing a generated 6.3 MB binary).