Skip to content

DRAFT: Update in accord with OpenBTMixing updates#151

Open
jared321 wants to merge 6 commits intomainfrom
148OpenBTUpdates
Open

DRAFT: Update in accord with OpenBTMixing updates#151
jared321 wants to merge 6 commits intomainfrom
148OpenBTUpdates

Conversation

@jared321
Copy link
Copy Markdown
Contributor

@jared321 jared321 commented Feb 3, 2026

Pending Tasks

  • Once OpenBTMixing v1.1.3 is deployed to PyPI, revert changes to GH actions in this branch so that they pull down that latest version from PyPI and confirm that all actions are passing again
  • Synchronize with main after other current PRs are merged into main

PR Self-review

  • Confirm via manual testing that Taweret can be installed with no need to preinstall meson or ninja and that it can be built with no eigen installation as well as with preexisting eigen v3 and v5 installations.
    • macOS using MPICH installed via homebrew, Taweret v1.2.0 and openbtmixing v1.1.3 pulled down from PyPI, and eigen v3.4.1 and v5.0.1 installed via homebrew. I saw correct compiler flags pointing to eigen installations as well.
    • Both meson and ninja were automatically downloaded and installed as expected.
    • I did see an openbtmixing v1.1.2 build with eigen v5.0.0 fail due to incompatible C++ standards. I believe that this was the original error found by Stefan.
    • This confirms that Taweret and SmoothEmulator installations should no longer enter into conflict due to eigen installations.
  • Review all changes made here
  • Review updated User Guide content as rendered by RTD in this PR
  • Confirm all actions passing

See OpenBTMixing PR 20.  HTML docs build looked good.
@jared321 jared321 self-assigned this Feb 3, 2026
@jared321 jared321 changed the title Update in accord with OpenBTMixing updates DRAFT: Update in accord with OpenBTMixing updates Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.10%. Comparing base (c406a48) to head (08b48cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   67.10%   67.10%           
=======================================
  Files          14       14           
  Lines        1207     1207           
=======================================
  Hits          810      810           
  Misses        397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asemposki
Copy link
Copy Markdown
Member

OK I'll check this out.

These lines were in the Taweret docs because such hints were not provided in the
OpenBTMixing installation notes.  However, I have transferred those lines over
to the OpenBTMixing notes.  This (hopefully) finalizes the decoupling of these
two packages.
@jared321 jared321 requested a review from asemposki April 23, 2026 21:10
@jared321
Copy link
Copy Markdown
Contributor Author

@asemposki Could you please review the full set of Taweret
https://taweretdocs--151.org.readthedocs.build/en/151/installation.html
and (Python-only) OpenBTMixing installation instructions
https://github.com/jcyannotty/OpenBT/blob/main/README.md

If possible, could you also try to install Taweret with no meson, no ninja, and no eigen installations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants