Skip to content

Add Windows 64b build to CI#275

Merged
bart6114 merged 4 commits into
bart6114:mainfrom
igitur:add-windows-build
Mar 12, 2026
Merged

Add Windows 64b build to CI#275
bart6114 merged 4 commits into
bart6114:mainfrom
igitur:add-windows-build

Conversation

@igitur
Copy link
Copy Markdown
Contributor

@igitur igitur commented Jul 2, 2025

Add Windows 64b build to CI

@bart6114
Copy link
Copy Markdown
Owner

bart6114 commented Jul 6, 2025

Thanks for this @igitur.
Where you able to test the binaries? I don't have access to a win machine.

We should prolly run tests against the architecture as well 🤔

@igitur
Copy link
Copy Markdown
Contributor Author

igitur commented Jul 6, 2025

I've been manually building the Windows binaries all the time and been using it for semi-production work. I wrap the cheek command in nssm so that it launches automatically when my server reboots.

But sure, after you release, I'll check again.

Will look into the tests too and update PR.

@bart6114
Copy link
Copy Markdown
Owner

bart6114 commented Jul 7, 2025

WDYT, should we add something like this to the tests job? And include it in this pr?

  tests:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [ubuntu-latest, windows-latest]

@igitur
Copy link
Copy Markdown
Contributor Author

igitur commented Jul 7, 2025

Ok, it's a bit more work than that, because a lot of the test data includes sh -c ... kind of commands.

@igitur
Copy link
Copy Markdown
Contributor Author

igitur commented Mar 12, 2026

The full Windows CI is proving to be a bit challenging (see previous comments). But are you OK with at least producing the Windows binary without running the tests on Windows? The assumption then is that if the tests pass on Linux/Darwin, then the test would also have passed on Windows. At least this isn't a regresssion, because currently there is no Windows CI at all.

igitur added 4 commits March 12, 2026 13:16
Add CI tests for Windows platform

Run tests on both Ubuntu and Windows to ensure cross-platform
compatibility.

Add bash shell for consistent cross-platform runs
@igitur igitur force-pushed the add-windows-build branch from 608a2d0 to f3c9df5 Compare March 12, 2026 11:18
@igitur
Copy link
Copy Markdown
Contributor Author

igitur commented Mar 12, 2026

Ignore the previous comment. I now know that the Windows runners have Bash installed via Git for Bash. This PR should now run successfully and build cheek for Windows and run the test suite. I had to skip 2 tests for Windows though. I can look into refactoring those tests if required.

@bart6114 bart6114 merged commit 0068a7a into bart6114:main Mar 12, 2026
14 checks passed
@bart6114
Copy link
Copy Markdown
Owner

Thanks a lot, please verify the new build artifacts when available as I don't have access to a win machine. When everything works, could you perhaps also add the build artifacts to the docs? Thanks!

@igitur igitur deleted the add-windows-build branch March 12, 2026 14:01
@igitur
Copy link
Copy Markdown
Contributor Author

igitur commented Mar 12, 2026

Thanks, I downloaded the amd build from the new release. Everything works 100% except, cheek.exe version yields development instead of the actual version number. I will investigate later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants