Add Windows 64b build to CI#275
Conversation
|
Thanks for this @igitur. We should prolly run tests against the architecture as well 🤔 |
|
I've been manually building the Windows binaries all the time and been using it for semi-production work. I wrap the cheek command in nssm so that it launches automatically when my server reboots. But sure, after you release, I'll check again. Will look into the tests too and update PR. |
|
WDYT, should we add something like this to the |
|
Ok, it's a bit more work than that, because a lot of the test data includes |
|
The full Windows CI is proving to be a bit challenging (see previous comments). But are you OK with at least producing the Windows binary without running the tests on Windows? The assumption then is that if the tests pass on Linux/Darwin, then the test would also have passed on Windows. At least this isn't a regresssion, because currently there is no Windows CI at all. |
Add CI tests for Windows platform Run tests on both Ubuntu and Windows to ensure cross-platform compatibility. Add bash shell for consistent cross-platform runs
608a2d0 to
f3c9df5
Compare
|
Ignore the previous comment. I now know that the Windows runners have Bash installed via Git for Bash. This PR should now run successfully and build cheek for Windows and run the test suite. I had to skip 2 tests for Windows though. I can look into refactoring those tests if required. |
|
Thanks a lot, please verify the new build artifacts when available as I don't have access to a win machine. When everything works, could you perhaps also add the build artifacts to the docs? Thanks! |
|
Thanks, I downloaded the amd build from the new release. Everything works 100% except, |
Add Windows 64b build to CI