Remove per-signer PCR0 from registry, validate against AggregateVerifier's TEE_IMAGE_HASH#221
Merged
leopoldjoy merged 5 commits intomainfrom Mar 25, 2026
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
7369152 to
391df64
Compare
…erifier at registration
391df64 to
563ae11
Compare
…meType with image hash check
roger-bai-coinbase
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TEEProverRegistrypreviously stored a PCR0 hash per signer and validated it against a manually-managed allowlist (validPCR0s). TheTEEVerifierthen checked it again on every proof verification against theAggregateVerifier'sTEE_IMAGE_HASH. This was redundant and required manual PCR0 pre-registration.This PR replaces both mechanisms with a single approach: at signer registration time, the attestation's PCR0 is validated against the
TEE_IMAGE_HASHread live from the currentAggregateVerifierimplementation via theDisputeGameFactory. This keeps the registration-time gate (only signers from the correct enclave image can register) while eliminating the per-signer PCR0 storage and the manual allowlist.Changes:
signerPCR0mapping withisRegisteredSignerboolean mappingvalidPCR0s,registerPCR0(),deregisterPCR0()from registrydisputeGameFactoryandgameTypeto registry (owner-settable, also passable viainitialize())registerSigner()now readsTEE_IMAGE_HASHfrom the factory'sAggregateVerifierand compares against the attestation's PCR0isValidSigner()instead of comparing PCR0 values; removeImageIdMismatcherroraddDevSigner(address)— no longer takes apcr0Hashparameter