refactor: use uint64 for L2 sequence numbers in AggregateVerifier#222
Merged
leopoldjoy merged 3 commits intomainfrom Mar 25, 2026
Merged
refactor: use uint64 for L2 sequence numbers in AggregateVerifier#222leopoldjoy merged 3 commits intomainfrom
leopoldjoy merged 3 commits intomainfrom
Conversation
Collaborator
✅ Heimdall Review Status
|
…eNumber in AggregateVerifier
mw2000
previously approved these changes
Mar 25, 2026
620b148 to
d3cd59c
Compare
|
Nice |
…egateVerifier hashes
Approved review 4003575916 from mw2000 is now dismissed due to new commit. Re-request for approval.
roger-bai-coinbase
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startingL2SequenceNumberandendingL2SequenceNumberfromuint256touint64inAggregateVerifier's internal functions (_verifyProof,_verifyTeeProof,_verifyZkProof,_getStartingIntermediateRootAndL2SequenceNumbers)uint64()casts at call sites inprove()andverifyProposalProof()where values originate from theuint256Proposal structabi.encodePackedjournal encoding (8 bytes vs 32 bytes per sequence number), so off-chain TEE / ZK provers must be updated to matchNOTE: Alternatively, we could change
Proposal.l2SequenceNumberinTypes.soltouint64directly, which would eliminate the casts added here but requires updating ~8 interface files and 5 implementation return types (all mechanical, no logic changes).Test plan
forge buildpassesuint64encoding