Skip to content

feat: add rootCert, proofSubmitter, and zkConfig to NitroEnclaveVerifier constructor#223

Merged
leopoldjoy merged 1 commit intomainfrom
feat/nitro-enclave-verifier-constructor-params
Mar 25, 2026
Merged

feat: add rootCert, proofSubmitter, and zkConfig to NitroEnclaveVerifier constructor#223
leopoldjoy merged 1 commit intomainfrom
feat/nitro-enclave-verifier-constructor-params

Conversation

@leopoldjoy
Copy link
Contributor

Summary

  • Adds _rootCert, _proofSubmitter, _zkCoProcessor, _zkConfig, and _verifierProofId as constructor parameters to NitroEnclaveVerifier, eliminating the need for separate post-deployment owner calls to setRootCert, setProofSubmitter, and setZkConfiguration
  • The existing setters are retained for post-deployment updates
  • Updates the test setUp to pass all values at construction time

Test plan

  • All 64 NitroEnclaveVerifierTest tests pass

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 25, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@leopoldjoy leopoldjoy merged commit 904ac46 into main Mar 25, 2026
8 checks passed
@leopoldjoy leopoldjoy deleted the feat/nitro-enclave-verifier-constructor-params branch March 25, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants