Skip to content

fix: change storage to memory in Drippie.executable() view functiont.#224

Open
zunixport wants to merge 1 commit intobase:mainfrom
zunixport:fix-drippie-storage-memory-bug
Open

fix: change storage to memory in Drippie.executable() view functiont.#224
zunixport wants to merge 1 commit intobase:mainfrom
zunixport:fix-drippie-storage-memory-bug

Conversation

@zunixport
Copy link

Problem

The executable() function in Drippie.sol was incorrectly using storage instead of memory for a local state variable, despite being marked as a view function.

Impact

  • Violated the view function contract by implying storage modification
  • Could cause compilation issues
  • Inefficient gas usage due to incorrect memory handling

Solution

Changed DripState storage state to DripState memory state on line 174 in the executable() function.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants