Skip to content

Feat: add semver and clean up param naming in NitroEnclaveVerifier#225

Merged
leopoldjoy merged 3 commits intomainfrom
feat/nitro-enclave-verifier-semver
Mar 25, 2026
Merged

Feat: add semver and clean up param naming in NitroEnclaveVerifier#225
leopoldjoy merged 3 commits intomainfrom
feat/nitro-enclave-verifier-semver

Conversation

@leopoldjoy
Copy link
Contributor

Summary

  • Adds ISemver and a version() function (0.1.0) to NitroEnclaveVerifier, consistent with TEEProverRegistry and TEEVerifier
  • Removes _ prefix from all function parameters per the convention used in Base's own multiproof contracts (reserved for private symbols like _verifierIdSet); state variable conflicts resolved with new/initial prefixes (e.g. newRootCert, initialMaxTimeDiff) and natural short forms (e.g. submitter, config)

Test plan

  • All 64 NitroEnclaveVerifierTest tests pass

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 25, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@leopoldjoy leopoldjoy changed the title feat: add semver and clean up param naming in NitroEnclaveVerifier Feat: add semver and clean up param naming in NitroEnclaveVerifier Mar 25, 2026
@leopoldjoy leopoldjoy merged commit 1c3a9c6 into main Mar 25, 2026
8 checks passed
@leopoldjoy leopoldjoy deleted the feat/nitro-enclave-verifier-semver branch March 25, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants