Skip to content

Conversation

@stevieraykatz
Copy link
Member

What changed? Why?
We need to use the full basename when setting primary records on the L2ReverseRegistrar.

Notes to reviewers

How has it been tested?

Have you tested the following pages?

BaseWeb

  • [] base.org
  • [] base.org/names
  • [] base.org/builders
  • [] base.org/ecosystem
  • [] base.org/name/jesse
  • [] base.org/manage-names
  • [] base.org/resources

@linear
Copy link

linear bot commented Dec 23, 2025

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 23, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Dec 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
base-web Ready Ready Preview, Comment Dec 23, 2025 6:41pm

@stevieraykatz stevieraykatz merged commit 0f32e94 into master Dec 23, 2025
11 checks passed
@stevieraykatz stevieraykatz deleted the fix-scw-reverse branch December 23, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants