Skip to content

Modernize CcToolchain{Features,Variables}#28789

Open
fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum:335-artifact-chunk
Open

Modernize CcToolchain{Features,Variables}#28789
fmeum wants to merge 2 commits intobazelbuild:masterfrom
fmeum:335-artifact-chunk

Conversation

@fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 25, 2026

Description

Switch from abstract classes to interfaces to enable widespread migration to records and delete a bunch of dead code.

Motivation

Work towards enabling path mapping for cc_args by introducing a new StringChunk type (cerisier/toolchains_llvm_bootstrapped#335)

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Switch from abstract classes to interfaces to enable widespread migration to records and delete a bunch of dead code.
@fmeum fmeum force-pushed the 335-artifact-chunk branch from 214e879 to 4d5a250 Compare February 25, 2026 11:53
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 25, 2026

@bazel-io fork 9.1.0

@fmeum
Copy link
Collaborator Author

fmeum commented Feb 25, 2026

#28794 will provide the implementation.

@iancha1992 iancha1992 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally team-Rules-CPP Issues for C++ rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants