[Docs Preview] Split the gRPC and non-gRPC parts of GrpcServerImpl into separate classes.#29021
Draft
copybara-service[bot] wants to merge 1 commit intomasterfrom
Draft
[Docs Preview] Split the gRPC and non-gRPC parts of GrpcServerImpl into separate classes.#29021copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
copybara_docs_preview_885212357
branch
2 times, most recently
from
1eb9839 to
a0ef120
Compare
copybara-service
bot
force-pushed
the
copybara_docs_preview_885212357
branch
2 times, most recently
from
7433693 to
f8e6cca
Compare
…sses. This makes it possible for a followup to move GrpcCommandServerImpl into the service component, while keeping CommandServer in the logic component (with GrpcCommandServer as the interface between them). There are some improvements yet to be made around exception handling in GrpcCommandServer.Responder (see comment in GrpcCommandServerImpl.BlockingStreamObserver) but I want to do them separately, as they entail some breakage risk. PiperOrigin-RevId: 885212357
copybara-service
bot
force-pushed
the
copybara_docs_preview_885212357
branch
from
f8e6cca to
4253189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split the gRPC and non-gRPC parts of GrpcServerImpl into separate classes.
This makes it possible for a followup to move GrpcCommandServerImpl into the service component, while keeping CommandServer in the logic component (with GrpcCommandServer as the interface between them).
There are some improvements yet to be made around exception handling in GrpcCommandServer.Responder (see comment in GrpcCommandServerImpl.BlockingStreamObserver) but I want to do them separately, as they entail some breakage risk.