Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
-fstack-usageby adding agenerate_stack_usagefeature. I roughly tried to follow thegenerate_linkmapfeature as a template.I left Windows support out because it seems like MSVC doesn't support this and I have no Windows machine to test on, but I can look into this if desired.
If this PR is roughly acceptable I would also like to contribute a similar PR for GCC's
-fcallgraph-info. The motivation is for an embedded target I could compute necessary stack usage at build time and give each processor on my target exactly the amount of stack it needs to not waste any IRAM space which I only have tens of kilobytes of.I'm not sure if this is the correct approach, or if something that solves this problem in a more general way (like a fix for #594) is preferred. Apologies if this is naive in some way, this is at (or past!) the limits of my bazel knowledge 😃
Example usage: